Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So.. I tried to do it as suggested in the issue's description, but I don't know how to move forward...
loading
attribute inapp/ui/omni-box.js
, and emit the events fromapp/window.js
, which I then listen for inapp/ui/script.js
. This then changes the attribute's value to eithertrue
orfalse
depending on the event.app/ui/style.css
named.spinner
.The issue is;
attributeChangedCallback
correctly. I addedthis.loader = this.$('omni-box-button')
and usethis.loader.getElementById().classList.toggle()
to either make the buttons hidden or visible, but they both stay constantly visible...loading
directly inapp/ui/script.js
when listening for the event, but I'm not sure whether that's even correct, or I should handle it some other way?Any suggestions on how to move from here ?